2317/Copy data from grants-db into the opportunity table(s) in the analytics db #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
chouinar
reviewed
Dec 17, 2024
analytics/src/analytics/integrations/extracts/load_opportunity_data.py
Outdated
Show resolved
Hide resolved
chouinar
reviewed
Dec 17, 2024
analytics/src/analytics/integrations/extracts/load_opportunity_data.py
Outdated
Show resolved
Hide resolved
… 2317/copy_opp_data_to_analytics
… 2317/copy_opp_data_to_analytics
doug-s-nava
pushed a commit
that referenced
this pull request
Dec 30, 2024
…alytics db (#3228) ## Summary Fixes #{[2317](#2317)} ### Time to review: __20 mins__ ## Changes proposed New Cli Function to upload opportunity tables into analytics db S3 configuration to read `csv `opportunity tables Add S3 Environment variables Mock s3 client for testing Added fixtures for AWS (From API code), test-schema and opportunity-tables to aid in testing, scoped to test session. Added fixture to delete table records after each test Added opportunity table `csv` files for testing Added test that checks files were successfully uploaded and records inserted into test-schema tables ## Context for reviewers > poetry run pytest ./tests/integrations/extracts/test_load_opportunity_data.py when running test locally ## Additional information > Screenshots, GIF demos, code examples or output to help show the changes working as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #{2317}
Time to review: 20 mins
Changes proposed
New Cli Function to upload opportunity tables into analytics db
S3 configuration to read
csvopportunity tablesAdd S3 Environment variables
Mock s3 client for testing
Added fixtures for AWS (From API code), test-schema and opportunity-tables to aid in testing, scoped to test session.
Added fixture to delete table records after each test
Added opportunity table
csvfiles for testingAdded test that checks files were successfully uploaded and records inserted into test-schema tables
Context for reviewers
Additional information